geiser/elisp/geiser-company.el, branch 0.33emacs and scheme talk to each otherhttps://jao.io/cgit/geiser/atom?h=0.332022-04-23T15:01:15ZSuggestive patch for simplified completion2022-04-23T15:01:15ZDaniel Mendlermail@daniel-mendler.de2022-04-02T00:19:54Zurn:sha1:18faa0ba32c9ce751c16960b2a39b3880b523272
NOTE: The patch is largely untested.
Modifications:
- Update readme.org
- Remove geiser-company
- Move Company extensions to geiser-completion
Omissions:
- geiser-company--inhibit-autodoc has been removed. Eldoc handling
should be implemented in the frontend, not in the backend.
See for example:
https://github.com/minad/corfu/blob/04fbfce3d7e9c125a7fd22a34455a508247a522b/corfu.el#L1212
- The quickhelp-string action and geiser-company--docstring have been
removed. company-quickhelp can use `:company-doc-buffer` instead with
minimal overhead.
See:
https://github.com/company-mode/company-quickhelp/blob/3ca2708b4e5190205aca01d65fe1b391963a53f9/company-quickhelp.el#L138
- The automatic Company setup has been removed. Personally I am not a
fan of such auto configuration. It is better if completion is
configured consistently in the user configuration. You may want to
restore the auto configuration for backward compatibility. It depends
on your backward compatibility story. I am fine with rare breaking
changes from time to time.
- There is a cyclic dependency between geiser-edit/geiser-doc and
geiser-completion, which should be untangled.
Byte-compilation warnings fixed2022-04-23T14:49:05Zjaojao@gnu.org2022-04-23T14:49:05Zurn:sha1:77adf19d3812ecfd821d250f8bc1eb821a88ee92
And, actually, fixing bugs: the warnings weren't spurious.
Use defvar-local2021-04-21T19:38:40ZJonas Bernoullijonas@bernoul.li2021-04-21T18:54:12Zurn:sha1:2b45bd368b4acbcef53c3c761725241fb6846102
It is available since Emacs 24.3 and we already depend on Emacs 24.4.
Use cl-lib instead of cl2020-03-27T22:13:37ZJonas Bernoullijonas@bernoul.li2020-03-27T22:13:37Zurn:sha1:8b07def2de860cbb4f4a28991572fb34b45a9941
Starting with Emacs 27 cl is fully deprecated, including at
compile-time.
Fix indentation2020-03-27T20:38:45ZJonas Bernoullijonas@bernoul.li2020-02-25T13:48:04Zurn:sha1:a11b96fe58a2579e15bfcb642f01e0059da59a87Mark the beginning of code part of elisp libraries with Code: heading2020-03-27T20:38:45ZJonas Bernoullijonas@bernoul.li2020-02-25T13:32:18Zurn:sha1:3ceb31b71824e59e3f000edf7cb09ab86616d723
It's the convention and by following it we make a big step towards
supporting outline navigation.
The convention doesn't say much about what parts of the code are
supposed to be part of that sections and what parts belong in a
subsequent section. Here we put the `require' forms in this section
and maybe some setup code, that's a popular approach.
In most cases there was " " where we now insert "Code:". They both
serve a similar purpose and we keep the former because some users
depend on that for navigation. We even add this " " in libraries
where it previously was missing.
In some cases the permission statement was followed by a commentary,
which obviously does not belong in the "Code:" section. In such cases
add the conventional "Commentary:" section.
Begin the summary lines of all elisp libraries with three semicolons2020-03-27T20:38:45ZJonas Bernoullijonas@bernoul.li2020-02-25T13:29:01Zurn:sha1:715f4c0ee0f50b251679e55650cedcae3a246b57
It's the convention and by following it we make a big step towards
supporting outline navigation.
Support 'quickhelp-string command for company-quickhelp2018-11-12T02:47:59ZAlexander Konstantinovakonst89+gitlab@gmail.com2018-08-02T23:33:17Zurn:sha1:c5cf86585d6948db36a2bdca4444682e9a8a36adMake the geiser-company 'doc-buffer command work again2018-11-11T23:27:38ZAlexander Konstantinovakonst89+gitlab@gmail.com2018-08-02T23:22:10Zurn:sha1:f2f63bdd2292d1f74748a880f4408de2c306201dPacify byte-compiler a bit2016-08-29T20:50:02ZFice Tfice-t@protonmail.com2016-08-14T05:09:02Zurn:sha1:c8148d9ebf34f37d4cbfb38d82222bb989f1b02a