From a614316ce70a060cb8b10557f7614fb3fda65b4c Mon Sep 17 00:00:00 2001 From: Jose Antonio Ortega Ruiz Date: Sun, 9 Jan 2011 00:06:46 +0100 Subject: Autodoc mode (de)activation fix. Quoth Mark: When the Geiser minor mode is toggled off using the command `geiser-mode', the message: Toggling eldoc-mode off; better pass an explicit argument. is displayed in the echo area. This is traceable to line 219: (eldoc-mode geiser-autodoc-mode) The function `eldoc-mode' takes numeric arguments, while `geiser-autodoc-mode' returns boolean values. Here is a simple patch: (eldoc-mode (if geiser-autodoc-mode 1 -1)) --- elisp/geiser-autodoc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'elisp/geiser-autodoc.el') diff --git a/elisp/geiser-autodoc.el b/elisp/geiser-autodoc.el index 3cb6204..88b94a1 100644 --- a/elisp/geiser-autodoc.el +++ b/elisp/geiser-autodoc.el @@ -216,7 +216,7 @@ displayed in the minibuffer." (when geiser-autodoc-mode 'geiser-autodoc--eldoc-function)) (set (make-local-variable 'eldoc-minor-mode-string) nil) (set (make-local-variable 'eldoc-idle-delay) geiser-autodoc-delay) - (eldoc-mode geiser-autodoc-mode) + (eldoc-mode (if geiser-autodoc-mode 1 -1)) (when (interactive-p) (message "Geiser Autodoc %s" (if geiser-autodoc-mode "enabled" "disabled")))) -- cgit v1.2.3