From 410a3a50d724c0aaf8d209d6a620976828854881 Mon Sep 17 00:00:00 2001 From: jao Date: Fri, 5 Jul 2024 14:52:33 +0100 Subject: further clarifications re geiser-custom A note on why we won't use the mapatom trick to make geiser-custom--defcustom obsolete while still preserving geiser-reload functionality (cf. !22). --- elisp/geiser-custom.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'elisp/geiser-custom.el') diff --git a/elisp/geiser-custom.el b/elisp/geiser-custom.el index 7125f11..f9b05a7 100644 --- a/elisp/geiser-custom.el +++ b/elisp/geiser-custom.el @@ -47,9 +47,12 @@ in the macro arguments." (defvar geiser-custom--memoized-vars nil) (defun geiser-custom--memoize (name) - ;; FIXME: Why not build this list with mapatoms, filtering on a "\\`'geiser-" + ;; Why not build this list with mapatoms, filtering on a "\\`'geiser-" ;; prefix and checking that it's a `defcustom', so we don't need - ;; `geiser-custom--defcustom'? + ;; `geiser-custom--defcustom'? Because implementation-specific modules using + ;; geiser may use similarly named custom variables that are, for some reason + ;; or another, not meant to partake in the geiser-reload mechanism, and we + ;; don't know their names. (add-to-list 'geiser-custom--memoized-vars name)) (defmacro geiser-custom--defcustom (name &rest body) -- cgit v1.2.3