From 67f727855895050aca3bcf37066e804dc8f307de Mon Sep 17 00:00:00 2001 From: Jonas Bernoulli Date: Thu, 14 Jul 2022 16:06:12 +0200 Subject: Define autoloads how that is normally done - Avoid defining autoload definitions in a central location. Instead add autoload cookies to the forms/definitions that should be autoloaded, in the locations where the actual definitions are located. - Do this for `geiser-mode', `turn-on-geiser-mode', `geiser-mode--maybe-activate' (including adding that to `scheme-mode-hook'), `geiser', `geiser-connect', `geiser-connect-local' and `geiser-repl-switch'. - Also do this for `run-geiser', even though it is only an obsolete function alias for `geiser', which might make it desirable to drop the autoload altogether. Some unusual autoload definitions remain in "geiser.el", see below. - One issue with defining autoloads in a central location is that it is easy to forget to remove such autoloads when the real definition is removed. No longer autoload `geiser-version' because since [1: 847d2ad] there no longer exists a proper definition of that function. - No longer autoload `geiser-unload', `geiser-reload' and `turn-off-geiser-mode', because they are only useful if Geiser has already been loaded, at which point any autoloaded definitions are no longer relevant. However, - Keep autoloading `geiser-activate-implementation' and `geiser-implementation-extension', even though I doubt that this is actually useful. - Keep using `custom-add-load' to specify dependencies of Custom groups and keep autoloading that. I don't know if this is actually necessary, and while it seems really weird, it might served a legit purpose, that I am not aware of. 1: 2020-07-19 847d2ad4c6da462c26c50af1ef7d9cd697f3a5d2 scheme and autotools removals --- elisp/geiser-repl.el | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'elisp/geiser-repl.el') diff --git a/elisp/geiser-repl.el b/elisp/geiser-repl.el index 698a394..6f6cea7 100644 --- a/elisp/geiser-repl.el +++ b/elisp/geiser-repl.el @@ -1099,20 +1099,24 @@ buffer." ;;; User commands +;;;###autoload (define-obsolete-function-alias 'run-geiser 'geiser "Geiser 0.26") +;;;###autoload (defun geiser (impl) "Start a new Geiser REPL." (interactive (list (geiser-repl--get-impl "Start Geiser for scheme implementation: "))) (geiser-repl--start-repl impl nil)) +;;;###autoload (defun geiser-connect (impl &optional host port) "Start a new Geiser REPL connected to a remote Scheme process." (interactive (list (geiser-repl--get-impl "Connect to Scheme implementation: "))) (geiser-repl--start-repl impl (geiser-repl--read-address host port))) +;;;###autoload (defun geiser-connect-local (impl socket) "Start a new Geiser REPL connected to a remote Scheme process over a Unix-domain socket." @@ -1142,6 +1146,7 @@ over a Unix-domain socket." (define-obsolete-function-alias 'switch-to-geiser 'geiser-repl-switch "0.26") +;;;###autoload (defun geiser-repl-switch (&optional ask impl buffer) "Switch to running Geiser REPL. -- cgit v1.2.3