hlint refactorings

15 files changed, 65 insertions, 61 deletions

diff --git a/src/Plugins/Monitors/Batt.hs b/src/Plugins/Monitors/Batt.hs
index 3eb2051..ac8cb24 100644
--- a/src/Plugins/Monitors/Batt.hs
+++ b/src/Plugins/Monitors/Batt.hs
@@ -105,7 +105,7 @@ batteryFiles bat =
   do is_charge <- exists "charge_now"
      is_energy <- if is_charge then return False else exists "energy_now"
      is_power <- exists "power_now"
-     plain <- if is_charge then exists "charge_full" else exists "energy_full"
+     plain <- exists (if is_charge then "charge_full" else "energy_full")
      let cf = if is_power then "power_now" else "current_now"
          sf = if plain then "" else "_design"
      return $ case (is_charge, is_energy) of
@@ -150,8 +150,9 @@ readBatteries opts bfs =
            time = if idle then 0 else sum $ map time' bats
            mwatts = if idle then 1 else sign * watts
            time' b = (if ac then full b - now b else now b) / mwatts
-           acstr = if idle then idleString opts else
-                     if ac then onString opts else offString opts
+           acstr | idle      = idleString opts
+                 | ac        = onString opts
+                 | otherwise = offString opts
        return $ if isNaN left then NA else Result left watts time acstr
 
 runBatt :: [String] -> Monitor String
diff --git a/src/Plugins/Monitors/Bright.hs b/src/Plugins/Monitors/Bright.hs
index 1c4cc01..d29c5a4 100644
--- a/src/Plugins/Monitors/Bright.hs
+++ b/src/Plugins/Monitors/Bright.hs
@@ -14,6 +14,7 @@
 
 module Plugins.Monitors.Bright (brightConfig, runBright) where
 
+import Control.Applicative ((<$>))
 import Control.Exception (SomeException, handle)
 import qualified Data.ByteString.Lazy.Char8 as B
 import System.FilePath ((</>))
@@ -60,12 +61,12 @@ data Files = Files { fCurr :: String
 
 brightFiles :: BrightOpts -> IO Files
 brightFiles opts = do
-  is_curr <- fileExist $ (fCurr files)
-  is_max  <- fileExist $ (fCurr files)
-  if is_curr && is_max then return files else return NoFiles
-  where prefix = sysDir </> (subDir opts)
-        files = Files { fCurr = prefix </> (currBright opts)
-                      , fMax = prefix </> (maxBright opts)
+  is_curr <- fileExist $ fCurr files
+  is_max  <- fileExist $ fCurr files
+  return (if is_curr && is_max then files else NoFiles)
+  where prefix = sysDir </> subDir opts
+        files = Files { fCurr = prefix </> currBright opts
+                      , fMax = prefix </> maxBright opts
                       }
 
 runBright :: [String] ->  Monitor String
@@ -85,9 +86,9 @@ runBright args = do
 readBright :: Files -> IO Float
 readBright NoFiles = return 0
 readBright files = do
-  currVal<- grab $ (fCurr files)
-  maxVal <- grab $ (fMax files)
-  return $ (currVal / maxVal)
-  where grab f = handle handler (fmap (read . B.unpack) $ B.readFile f)
+  currVal<- grab $ fCurr files
+  maxVal <- grab $ fMax files
+  return (currVal / maxVal)
+  where grab f = handle handler (read . B.unpack <$> B.readFile f)
         handler = const (return 0) :: SomeException -> IO Float
 
diff --git a/src/Plugins/Monitors/CatInt.hs b/src/Plugins/Monitors/CatInt.hs
index 3d19270..aacbd71 100644
--- a/src/Plugins/Monitors/CatInt.hs
+++ b/src/Plugins/Monitors/CatInt.hs
@@ -20,6 +20,6 @@ catIntConfig = mkMConfig "<v>" ["v"]
 
 runCatInt :: FilePath -> [String] -> Monitor String
 runCatInt p _ =
-  let failureMessage = "Cannot read: " ++ (show p)
+  let failureMessage = "Cannot read: " ++ show p
       fmt x = show (truncate x :: Int)
   in  checkedDataRetrieval failureMessage [[p]] Nothing id fmt
diff --git a/src/Plugins/Monitors/Common.hs b/src/Plugins/Monitors/Common.hs
index 70f1b5f..1fd09a6 100644
--- a/src/Plugins/Monitors/Common.hs
+++ b/src/Plugins/Monitors/Common.hs
@@ -60,6 +60,7 @@ module Plugins.Monitors.Common (
                        ) where
 
 
+import Control.Applicative ((<$>))
 import Control.Monad.Reader
 import qualified Data.ByteString.Lazy.Char8 as B
 import Data.IORef
@@ -112,7 +113,7 @@ mods s m =
 
 setConfigValue :: a -> Selector a -> Monitor ()
 setConfigValue v s =
-       mods s (\_ -> v)
+       mods s (const v)
 
 getConfigValue :: Selector a -> Monitor a
 getConfigValue = sel
@@ -342,7 +343,7 @@ combine m ((s,ts,ss):xs) =
     do next <- combine m xs
        str <- case Map.lookup ts m of
          Nothing -> return $ "<" ++ ts ++ ">"
-         Just  r -> let f "" = r; f n = n; in fmap f $ parseTemplate' r m
+         Just  r -> let f "" = r; f n = n; in f <$> parseTemplate' r m
        return $ s ++ str ++ ss ++ next
 
 -- $strings
@@ -459,7 +460,7 @@ showVerticalBar v x = colorizeString v [convert $ 100 * x]
           | t <= 9600 = ' '
           | t > 9608 = chr 9608
           | otherwise = chr t
-          where t = 9600 + ((round val) `div` 12)
+          where t = 9600 + (round val `div` 12)
 
 showLogBar :: Float -> Float -> Monitor String
 showLogBar f v = do
diff --git a/src/Plugins/Monitors/CoreTemp.hs b/src/Plugins/Monitors/CoreTemp.hs
index bfe9aca..e19baf0 100644
--- a/src/Plugins/Monitors/CoreTemp.hs
+++ b/src/Plugins/Monitors/CoreTemp.hs
@@ -27,8 +27,8 @@ import Data.Char (isDigit)
 coreTempConfig :: IO MConfig
 coreTempConfig = mkMConfig
        "Temp: <core0>C" -- template
-       (zipWith (++) (repeat "core") (map show [0 :: Int ..])) -- available
-                                                               -- replacements
+       (map ((++) "core" . show) [0 :: Int ..]) -- available
+                                                -- replacements
 
 -- |
 -- Function retrieves monitor string holding the core temperature
@@ -39,7 +39,7 @@ runCoreTemp _ = do
    failureMessage <- getConfigValue naString
    let path = ["/sys/bus/platform/devices/coretemp.", "/temp", "_input"]
        path' = ["/sys/bus/platform/devices/coretemp.", "/hwmon/hwmon", "/temp", "_input"]
-       lbl  = Just ("_label", read . (dropWhile (not . isDigit)))
+       lbl  = Just ("_label", read . dropWhile (not . isDigit))
        divisor = 1e3 :: Double
        show' = showDigits (max 0 dn)
    checkedDataRetrieval failureMessage [path, path'] lbl (/divisor) show'
diff --git a/src/Plugins/Monitors/Cpu.hs b/src/Plugins/Monitors/Cpu.hs
index df2dc4e..10d945f 100644
--- a/src/Plugins/Monitors/Cpu.hs
+++ b/src/Plugins/Monitors/Cpu.hs
@@ -38,8 +38,8 @@ parseCpu cref =
        b <- cpuData
        writeIORef cref b
        let dif = zipWith (-) b a
-           tot = fromIntegral $ foldr (+) 0 dif
-           percent = map (/ tot) (map fromIntegral dif)
+           tot = fromIntegral $ sum dif
+           percent = map ((/ tot) . fromIntegral) dif
        return percent
 
 formatCpu :: [Float] -> Monitor [String]
diff --git a/src/Plugins/Monitors/CpuFreq.hs b/src/Plugins/Monitors/CpuFreq.hs
index 3fe2577..d3ecf89 100644
--- a/src/Plugins/Monitors/CpuFreq.hs
+++ b/src/Plugins/Monitors/CpuFreq.hs
@@ -24,8 +24,8 @@ import Plugins.Monitors.CoreCommon
 cpuFreqConfig :: IO MConfig
 cpuFreqConfig = mkMConfig
        "Freq: <cpu0>" -- template
-       (zipWith (++) (repeat "cpu") (map show [0 :: Int ..])) -- available
-                                                              -- replacements
+       (map ((++) "cpu" . show) [0 :: Int ..]) -- available
+                                             -- replacements
 
 -- |
 -- Function retrieves monitor string holding the cpu frequency (or frequencies)
@@ -33,7 +33,7 @@ runCpuFreq :: [String] -> Monitor String
 runCpuFreq _ = do
   let path = ["/sys/devices/system/cpu/cpu", "/cpufreq/scaling_cur_freq"]
       divisor = 1e6 :: Double
-      fmt x | x < 1 = (show (round (x * 1000) :: Integer)) ++ "MHz"
-            | otherwise = (show x) ++ "GHz"
+      fmt x | x < 1 = show (round (x * 1000) :: Integer) ++ "MHz"
+            | otherwise = show x ++ "GHz"
   failureMessage <- getConfigValue naString
   checkedDataRetrieval failureMessage [path] Nothing (/divisor) fmt
diff --git a/src/Plugins/Monitors/Disk.hs b/src/Plugins/Monitors/Disk.hs
index e0a7886..4cc2865 100644
--- a/src/Plugins/Monitors/Disk.hs
+++ b/src/Plugins/Monitors/Disk.hs
@@ -63,10 +63,10 @@ diskDevices req = do
   s <- B.readFile "/proc/diskstats"
   parse `fmap` mapM canon (devs s)
   where
-    canon (d, p) = do {d' <- canonicalizePath (d); return (d', p)}
+    canon (d, p) = do {d' <- canonicalizePath d; return (d', p)}
     devs = map (third . B.words) . B.lines
     parse = map undev . filter isReq
-    third (_:_:c:_) = ("/dev/" ++ (B.unpack c), B.unpack c)
+    third (_:_:c:_) = ("/dev/" ++ B.unpack c, B.unpack c)
     third _ = ("", "")
     isReq (d, p) = p `elem` req || drop 5 d `elem` req
     undev (d, f) = (drop 5 d, f)
diff --git a/src/Plugins/Monitors/Mem.hs b/src/Plugins/Monitors/Mem.hs
index e409095..db2e5de 100644
--- a/src/Plugins/Monitors/Mem.hs
+++ b/src/Plugins/Monitors/Mem.hs
@@ -30,10 +30,10 @@ parseMEM :: IO [Float]
 parseMEM =
     do file <- fileMEM
        let content = map words $ take 8 $ lines file
-           info = M.fromList $ map (\line -> (line !! 0, (read $ line !! 1 :: Float) / 1024)) content
+           info = M.fromList $ map (\line -> (head line, (read $ line !! 1 :: Float) / 1024)) content
            [total, free, buffer, cache] = map (info M.!) ["MemTotal:", "MemFree:", "Buffers:", "Cached:"]
            rest = free + buffer + cache
-           used = total - (M.findWithDefault rest "MemAvailable:" info)
+           used = total - M.findWithDefault rest "MemAvailable:" info
            usedratio = used / total
            freeratio = free / total
        return [usedratio, freeratio, total, free, buffer, cache, rest, used, freeratio]
diff --git a/src/Plugins/Monitors/Mpris.hs b/src/Plugins/Monitors/Mpris.hs
index 98b4c0f..245c0df 100644
--- a/src/Plugins/Monitors/Mpris.hs
+++ b/src/Plugins/Monitors/Mpris.hs
@@ -25,6 +25,7 @@ import Text.Printf (printf)
 import DBus
 import qualified DBus.Client as DC
 
+import Control.Arrow ((***))
 import Data.Maybe ( fromJust )
 import Data.Int ( Int32, Int64 )
 import System.IO.Unsafe (unsafePerformIO)
@@ -43,10 +44,10 @@ instance MprisVersion MprisVersion1 where
         { methodCallDestination = Just busName
         }
         where
-        busName       = busName_       $ "org.mpris." ++ p
-        objectPath    = objectPath_    $ "/Player"
-        interfaceName = interfaceName_ $ "org.freedesktop.MediaPlayer"
-        memberName    = memberName_    $ "GetMetadata"
+        busName       = busName_     $ "org.mpris." ++ p
+        objectPath    = objectPath_    "/Player"
+        interfaceName = interfaceName_ "org.freedesktop.MediaPlayer"
+        memberName    = memberName_    "GetMetadata"
 
     fieldsList MprisVersion1 = [ "album", "artist", "arturl", "mtime", "title"
                                , "tracknumber" ]
@@ -58,10 +59,10 @@ instance MprisVersion MprisVersion2 where
         , methodCallBody = arguments
         }
         where
-        busName       = busName_       $ "org.mpris.MediaPlayer2." ++ p
-        objectPath    = objectPath_    $ "/org/mpris/MediaPlayer2"
-        interfaceName = interfaceName_ $ "org.freedesktop.DBus.Properties"
-        memberName    = memberName_    $ "Get"
+        busName       = busName_     $ "org.mpris.MediaPlayer2." ++ p
+        objectPath    = objectPath_    "/org/mpris/MediaPlayer2"
+        interfaceName = interfaceName_ "org.freedesktop.DBus.Properties"
+        memberName    = memberName_    "Get"
         arguments     = map (toVariant::String -> Variant)
                             ["org.mpris.MediaPlayer2.Player", "Metadata"]
 
@@ -98,7 +99,7 @@ fromVar = fromJust . fromVariant
 
 unpackMetadata :: [Variant] -> [(String, Variant)]
 unpackMetadata [] = []
-unpackMetadata xs = ((map (\(k, v) -> (fromVar k, fromVar v))) . unpack . head) xs where
+unpackMetadata xs = (map (fromVar *** fromVar) . unpack . head) xs where
                       unpack v = case variantType v of
                             TypeDictionary _ _ -> dictionaryItems $ fromVar v
                             TypeVariant -> unpack $ fromVar v
diff --git a/src/Plugins/Monitors/MultiCpu.hs b/src/Plugins/Monitors/MultiCpu.hs
index 429c38a..150fb7e 100644
--- a/src/Plugins/Monitors/MultiCpu.hs
+++ b/src/Plugins/Monitors/MultiCpu.hs
@@ -15,6 +15,7 @@
 module Plugins.Monitors.MultiCpu (startMultiCpu) where
 
 import Plugins.Monitors.Common
+import Control.Applicative ((<$>))
 import qualified Data.ByteString.Lazy.Char8 as B
 import Data.List (isPrefixOf, transpose, unfoldr)
 import Data.IORef (IORef, newIORef, readIORef, writeIORef)
@@ -52,16 +53,16 @@ parseCpuData cref =
 percent :: [Float] -> [Float] -> [Float]
 percent b a = if tot > 0 then map (/ tot) $ take 4 dif else [0, 0, 0, 0]
   where dif = zipWith (-) b a
-        tot = foldr (+) 0 dif
+        tot = sum dif
 
 formatMultiCpus :: [[Float]] -> Monitor [String]
 formatMultiCpus [] = return []
-formatMultiCpus xs = fmap concat $ mapM formatCpu xs
+formatMultiCpus xs = concat <$> mapM formatCpu xs
 
 formatCpu :: [Float] -> Monitor [String]
 formatCpu xs
   | length xs < 4 = showPercentsWithColors $ replicate vNum 0.0
-  | otherwise = let t = foldr (+) 0 $ take 3 xs
+  | otherwise = let t = sum $ take 3 xs
                 in do b <- showPercentBar (100 * t) t
                       h <- showVerticalBar (100 * t) t
                       ps <- showPercentsWithColors (t:xs)
diff --git a/src/Plugins/Monitors/Net.hs b/src/Plugins/Monitors/Net.hs
index 31dc411..39bdd61 100644
--- a/src/Plugins/Monitors/Net.hs
+++ b/src/Plugins/Monitors/Net.hs
@@ -22,7 +22,7 @@ import Plugins.Monitors.Common
 
 import Data.IORef (IORef, newIORef, readIORef, writeIORef)
 import Data.Time.Clock (UTCTime, getCurrentTime, diffUTCTime)
-import Control.Monad (forM, filterM)
+import Control.Monad (forM, filterM, liftM)
 import System.Directory (getDirectoryContents, doesFileExist)
 import System.FilePath ((</>))
 
@@ -147,11 +147,11 @@ runNet :: NetDevRef -> String -> [String] -> Monitor String
 runNet nref i _ = io (parseNet nref i) >>= printNet
 
 parseNets :: [(NetDevRef, String)] -> IO [NetDev]
-parseNets = mapM $ \(ref, i) -> parseNet ref i
+parseNets = mapM $ uncurry parseNet
 
 runNets :: [(NetDevRef, String)] -> [String] -> Monitor String
 runNets refs _ = io (parseActive refs) >>= printNet
-    where parseActive refs' = parseNets refs' >>= return . selectActive
+    where parseActive refs' = liftM selectActive (parseNets refs') 
           selectActive = maximum
 
 startNet :: String -> [String] -> Int -> (String -> IO ()) -> IO ()
diff --git a/src/Plugins/Monitors/Swap.hs b/src/Plugins/Monitors/Swap.hs
index 107eb1e..b6c5019 100644
--- a/src/Plugins/Monitors/Swap.hs
+++ b/src/Plugins/Monitors/Swap.hs
@@ -33,8 +33,8 @@ parseMEM =
                | l /= [] = head l !! i
                | otherwise = B.empty
            fs s l
-               | l == []    = False
-               | otherwise  = head l == B.pack s
+               | null l    = False
+               | otherwise = head l == B.pack s
            get_data s = flip (/) 1024 . read . B.unpack . li 1 . filter (fs s)
            st   = map B.words . B.lines $ file
            tot  = get_data "SwapTotal:" st
diff --git a/src/Plugins/Monitors/Thermal.hs b/src/Plugins/Monitors/Thermal.hs
index a3ffe6d..6013511 100644
--- a/src/Plugins/Monitors/Thermal.hs
+++ b/src/Plugins/Monitors/Thermal.hs
@@ -14,6 +14,7 @@
 
 module Plugins.Monitors.Thermal where
 
+import Control.Monad (liftM)
 import qualified Data.ByteString.Lazy.Char8 as B
 import Plugins.Monitors.Common
 import System.Posix.Files (fileExist)
@@ -32,11 +33,9 @@ runThermal args = do
     let zone = head args
         file = "/proc/acpi/thermal_zone/" ++ zone ++ "/temperature"
     exists <- io $ fileExist file
-    case exists of
-         False  -> return $ "Thermal (" ++ zone ++ "): N/A"
-         True   -> do number <- io $ B.readFile file
-                                     >>= return . (read :: String -> Int)
-                                                . stringParser (1, 0)
-                      thermal <- showWithColors show number
-                      parseTemplate [  thermal ]
+    if exists
+        then do number <- io $ liftM ((read :: String -> Int) . stringParser (1, 0)) (B.readFile file)
+                thermal <- showWithColors show number
+                parseTemplate [  thermal ]
+        else return $ "Thermal (" ++ zone ++ "): N/A"
 
diff --git a/src/Plugins/Monitors/Weather.hs b/src/Plugins/Monitors/Weather.hs
index dfc421e..ba4d911 100644
--- a/src/Plugins/Monitors/Weather.hs
+++ b/src/Plugins/Monitors/Weather.hs
@@ -68,7 +68,7 @@ pTime = do y <- getNumbersAsString
            char ' '
            (h:hh:mi:mimi) <- getNumbersAsString
            char ' '
-           return (y, m, d ,([h]++[hh]++":"++[mi]++mimi))
+           return (y, m, d ,[h]++[hh]++":"++[mi]++mimi)
 
 pTemp :: Parser (Int, Int)
 pTemp = do let num = digit <|> char '-' <|> char '.'
@@ -76,10 +76,10 @@ pTemp = do let num = digit <|> char '-' <|> char '.'
            manyTill anyChar $ char '('
            c <- manyTill num $ char ' '
            skipRestOfLine
-           return $ (floor (read c :: Double), floor (read f :: Double))
+           return (floor (read c :: Double), floor (read f :: Double))
 
 pRh :: Parser Int
-pRh = do s <- manyTill digit $ (char '%' <|> char '.')
+pRh = do s <- manyTill digit (char '%' <|> char '.')
          return $ read s
 
 pPressure :: Parser Int
@@ -123,7 +123,7 @@ parseData =
        skipTillString "Pressure (altimeter): "
        p <- pPressure
        manyTill skipRestOfLine eof
-       return $ [WI st ss y m d h w v sk tC tF dp rh p]
+       return [WI st ss y m d h w v sk tC tF dp rh p]
 
 defUrl :: String
 defUrl = "http://weather.noaa.gov/pub/data/observations/metar/decoded/"
@@ -139,7 +139,7 @@ getData station = do
           errHandler _ = return "<Could not retrieve data>"
 
 formatWeather :: [WeatherInfo] -> Monitor String
-formatWeather [(WI st ss y m d h w v sk tC tF dp r p)] =
+formatWeather [WI st ss y m d h w v sk tC tF dp r p] =
     do cel <- showWithColors show tC
        far <- showWithColors show tF
        parseTemplate [st, ss, y, m, d, h, w, v, sk, cel, far, dp, show r , show p ]
@@ -158,10 +158,10 @@ weatherReady str = do
     io $ CE.catch (simpleHTTP request >>= checkResult) errHandler
     where errHandler :: CE.IOException -> IO Bool
           errHandler _ = return False
-          checkResult result = do
+          checkResult result =
             case result of
                 Left _ -> return False
-                Right response -> do
+                Right response ->
                     case rspCode response of
                         -- Permission or network errors are failures; anything
                         -- else is recoverable.