diff options
| author | Anton Vorontsov <anton@enomsg.org> | 2014-09-16 15:48:49 -0700 | 
|---|---|---|
| committer | Anton Vorontsov <anton@enomsg.org> | 2014-09-16 20:20:10 -0700 | 
| commit | 73053ddf3386604f19b494afd9c234ac50427d6c (patch) | |
| tree | 9b11fc330277073806b73be3c075659784e239ea /src/Plugins/Monitors | |
| parent | a6933f49ae9bdc8cbd5bee42920e5b9a01c21e7f (diff) | |
| download | xmobar-73053ddf3386604f19b494afd9c234ac50427d6c.tar.gz xmobar-73053ddf3386604f19b494afd9c234ac50427d6c.tar.bz2  | |
Locks: Rework to avoid unnecessary display reopening
The extremely useful "Locks" plugin eats quite a lot of CPU (>2% here on a
old-ish laptop), unfortunately. The plug-in unnecessary reopens the
display, which is quite expensive operation. It results into 16 syscalls:
     socket(PF_LOCAL)      -> connect(sun_path=@"/tmp/.X11-unix/X0"})
  -> getpeername()         -> uname()
  -> access(".Xauthority") -> open(".Xauthority")
  -> fstat()               -> mmap()
  -> read()                -> close()
  -> munmap()              -> getsockname()
  -> fcntl(F_SETFD)        -> fcntl(F_SETFL)
  -> shutdown()            -> close()
This is almost half of all the syscalls that we ought to execute for the
plug-in to work. Now, considering the useful work and that "Locks" runs
every 200 milliseconds, it gives us >300 syscalls (and a lot more
wake-ups) per second.
This commit fixes the reopening issue, effectively halving the CPU
consumption (down to ~1%). The patch also makes it easier to implement
event-driven indicators that will reduce the idle CPU consumption to 0.
Diffstat (limited to 'src/Plugins/Monitors')
0 files changed, 0 insertions, 0 deletions
