From 32fc8214c567c7f4a4caad10fab98c760a1685b7 Mon Sep 17 00:00:00 2001 From: Tomas Janousek Date: Tue, 13 Aug 2019 21:41:15 +0200 Subject: Implement timer coalescing (noticeably less CPU/power usage) xmobar currently runs every monitor in its own thread. Monitors that do periodic updates simply sleep and loop. This unfortunately leads to these threads coming out of sync, and xmobar ends up waking up and redrawing for every periodic monitor. In my case, that is 7 times per second, which is enough for xmobar to be at the top of "top" with more than 1% CPU usage, and to have a noticeable impact on battery life. This commit adds a central timer coordination thread which makes sure that periodic updates happen together and that we only redraw once they're all done. Together with PR #409, I managed to lower the idle power draw of my laptop from 4W to 3W. --- xmobar.cabal | 2 ++ 1 file changed, 2 insertions(+) (limited to 'xmobar.cabal') diff --git a/xmobar.cabal b/xmobar.cabal index 1eff7ba..02dc87f 100644 --- a/xmobar.cabal +++ b/xmobar.cabal @@ -105,6 +105,7 @@ library Xmobar.App.Main, Xmobar.App.Opts, Xmobar.App.Compile, + Xmobar.App.Timer, Xmobar.System.Utils, Xmobar.System.StatFS, Xmobar.System.Environment, @@ -320,6 +321,7 @@ test-suite XmobarTest Xmobar.Plugins.Monitors.Common.Output Xmobar.Plugins.Monitors.Common.Files Xmobar.Run.Exec + Xmobar.App.Timer Xmobar.System.Signal if flag(with_alsa) || flag(all_extensions) -- cgit v1.2.3