diff options
| author | Daniel Mendler <mail@daniel-mendler.de> | 2022-04-02 02:19:54 +0200 |
|---|---|---|
| committer | jao <jao@gnu.org> | 2022-04-23 16:01:15 +0100 |
| commit | 18faa0ba32c9ce751c16960b2a39b3880b523272 (patch) | |
| tree | de834f9eccbe390421c495844b48af9ba8565a2d /elisp/geiser-repl.el | |
| parent | 77adf19d3812ecfd821d250f8bc1eb821a88ee92 (diff) | |
| download | geiser-18faa0ba32c9ce751c16960b2a39b3880b523272.tar.gz geiser-18faa0ba32c9ce751c16960b2a39b3880b523272.tar.bz2 | |
Suggestive patch for simplified completion
NOTE: The patch is largely untested.
Modifications:
- Update readme.org
- Remove geiser-company
- Move Company extensions to geiser-completion
Omissions:
- geiser-company--inhibit-autodoc has been removed. Eldoc handling
should be implemented in the frontend, not in the backend.
See for example:
https://github.com/minad/corfu/blob/04fbfce3d7e9c125a7fd22a34455a508247a522b/corfu.el#L1212
- The quickhelp-string action and geiser-company--docstring have been
removed. company-quickhelp can use `:company-doc-buffer` instead with
minimal overhead.
See:
https://github.com/company-mode/company-quickhelp/blob/3ca2708b4e5190205aca01d65fe1b391963a53f9/company-quickhelp.el#L138
- The automatic Company setup has been removed. Personally I am not a
fan of such auto configuration. It is better if completion is
configured consistently in the user configuration. You may want to
restore the auto configuration for backward compatibility. It depends
on your backward compatibility story. I am fine with rare breaking
changes from time to time.
- There is a cyclic dependency between geiser-edit/geiser-doc and
geiser-completion, which should be untangled.
Diffstat (limited to 'elisp/geiser-repl.el')
| -rw-r--r-- | elisp/geiser-repl.el | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/elisp/geiser-repl.el b/elisp/geiser-repl.el index b66e000..e9567b3 100644 --- a/elisp/geiser-repl.el +++ b/elisp/geiser-repl.el @@ -10,7 +10,6 @@ ;;; Code: -(require 'geiser-company) (require 'geiser-doc) (require 'geiser-autodoc) (require 'geiser-edit) @@ -106,10 +105,6 @@ change that." "Whether to enable `geiser-autodoc-mode' in the REPL by default." :type 'boolean) -(geiser-custom--defcustom geiser-repl-company-p t - "Whether to use company-mode for completion, if available." - :type 'boolean) - (geiser-custom--defcustom geiser-repl-read-only-prompt-p t "Whether the REPL's prompt should be read-only." :type 'boolean) @@ -560,7 +555,6 @@ will be set up using `geiser-connect-local' when a REPL is started.") (geiser-repl--connection-setup impl address prompt-rx deb-prompt-rx)) (geiser-repl--startup impl address) (geiser-repl--autodoc-mode 1) - (geiser-company--setup geiser-repl-company-p) (geiser-repl--set-up-load-path) (add-hook 'comint-output-filter-functions 'geiser-repl--output-filter |